overcommit icon indicating copy to clipboard operation
overcommit copied to clipboard

Add non ASCII encoding schema support to RailsSchemaUpToDate hook

Open ttrmw opened this issue 2 years ago • 3 comments

Adds the possibility of adding an encoding config item if you know your schema.rb or structure.sql file contains non ASCII characters, as in the case of the project I'm working on :grin:

It's possible you might also want this on migration files, but I haven't included that in this PR, let me know if that's something you'd like to see to get this merged.

ttrmw avatar May 06 '22 10:05 ttrmw

Hey @ttrmw, sorry for the delay in response.

It looks like the Ruby 3 tests are failing with real errors. There are also some spurious errors (timeouts) that can be ignored, but happy to merge once the Ruby 3 tests are passing. Thanks!

sds avatar May 24 '22 18:05 sds

Thanks! Will take a look at repro locally and push a fix.

ttrmw avatar May 24 '22 21:05 ttrmw

Hiya, my turn for a huge delay. @pajw has sorted the test failures out - please rerun CI at your convenience :grin:

ttrmw avatar Sep 15 '22 08:09 ttrmw

Sorry for the delay. Failures seem unrelated to your changes, going to go ahead and merge.

sds avatar Jan 20 '23 06:01 sds