Shane da Silva

Hey @ptarjan, that CSS looks perfectly valid to me from a syntactical perspective. If you are referring to the lack of units on padding, this kind of checking can get...

@ptarjan is there a documented list of CSS properties and their allowed units you could point to? That would make implementing this request pretty trivial.

The more I think about what's involved here the more I'm lead to the conclusion that Overcommit's use of the stack to save/restore changes needs to be replaced by an...

@rob-orr To my knowledge no one is currently working on this. Would happily welcome someone willing to tackle this and submit a pull request!

Open to a pull request!

You raise a good point, @deivid-rodriguez. It would be nice if Overcommit remembered all previously-signed configurations.

Would _love_ a PR addressing this, @benbernard! You'll need to modify the [`HookSigner`](https://github.com/brigade/overcommit/blob/v0.40.0/lib/overcommit/hook_signer.rb) class to support searching through a list of previously-verified signatures. This may involve creating a different storage...

Hey @benbernard, agree it's probably not crucial to address this, but I've seen some pretty weird use cases from users of this tool so I tend to not rule these...

Storing in `.git` makes sense to me. Agreed this should not be tracked by Git since that allows attackers to inject signatures in a pull request, bypassing the safety check.

Sorry for the delay in response. It's not clear to me why you're seeing this behavior. If you have a minimum repository reproduces the issue, it would help explain whether...