Shane da Silva comments

Results 170 comments of


                                            Shane da Silva

Linter ControlStatementSpacing raise incorrect `=`

Thanks for investigating! Given there is a workaround, I'm inclined to leave this issue open for someone with enough interest to fix. Will happily merge a pull request fixing the...

Linter ControlStatementSpacing raise incorrect `=`

Implemented in #164.

ControlStatementSpacing options

Happy to merge pull request that adds this as a configurable option.

Do not expect tags to all be lowercase when doctype xml

Happy to merge a pull request adding support!

Does it make sense to add a Slim syntax validity check?

Sorry for the delay in response. Supportive of a PR that adds the additional check!

Add support for port and different identity file in ssh config

Hey @gnufied, This is a great idea. Writing some integration tests to work with Vagrant would be interesting to try out. Rather than just allowing the identity file to be...

Array serialization does not work with custom array types

>Just merged a PR that should fix this https://github.com/porsager/postgres/pull/578 > >Can you check how that works? I still receive the same error with that change. >They probably still have to...

Array serialization does not work with custom array types

Here's a test that reproduces the failure: ```ts t('Insert array into custom domain array', async() => { await sql`create domain my_custom_array_type as text[]` await sql`create table test (x my_custom_array_type)` await...

False positive Rails/HttpStatus

Closing since a workaround has been provided. Thanks!

False positive with Layout/SpaceInsideParens for multi-line attributes

Going to close since a workaround has been provided. Thanks!