Sebastian Dröge

If all enums are behind a specific configuration there are unused imports in `src/auto/enums.rs`

5

Same probably also for `flags.rs`. See below ```rust use glib::translate::*; use glib::value::FromValue; use glib::value::FromValueOptional; use glib::value::SetValue; use glib::value::Value; use glib::StaticType; use glib::Type; use gobject_sys; use gst_base_sys; #[cfg(any(feature = "v1_18", feature...

Don't derive Copy for FFI structs/unions that contain pointers

1

In https://github.com/gtk-rs/gir/pull/415 we started deriving `Copy` for all FFI structs and unions. This can easily lead to double frees and related problems because it can be non-obvious from the code...

Currently there are various string special cases all over the code, many of them looking similarly. Searching for `is_gstring`, `is_str`, `GString` gives some of the worst places. This should probably...

Switch from xml-rs to quick-xml

1

The API is very similar so it shouldn't be too hard, and it's an order of magnitude faster.

For many functions it's more useful to include some of the function arguments in the string returned `glib::bool_error!`. I'd suggest a syntax like `bool_return_is_error = "blablabla {0} blablabla {1:?}"` for...

Add a way to connect to signals with `after=true`

18

See `g_signal_connect()` vs. `g_signal_connect_after()` in C. We can already do that via `ObjectExt::connect()` but it would be useful to also have this for the strongly typed signal connection functions. Any...

Use glib::Closure for signal connector functions

5

No need to use unsafe trampolines anymore.

Make use of new IO-safety API for raw fd handling

4

See https://github.com/rust-lang/rfcs/blob/master/text/3128-io-safety.md

`glib::closure!` macro and signal connector should use more descriptive assertions

2

E.g. currently when the number of arguments does not match one simply gets an assertion that e.g. `2 != 5` without any hints about the actual problem. CC @jf2048 @bilelmoussaoui

No way to know when a cancelled Future async operation is actually cancelled

5

https://github.com/rust-lang-nursery/futures-rs/issues/1278#issuecomment-428071710 Problem here is that the callback-based API would give us a `Cancelled` error at that time, while simply dropping the future allows for no way of signalling that the...