Lucas Molas

Results 112 comments of Lucas Molas

This fails when running it through the daemon, fixing.

It seems the iterator for `multipartDirectory` somehow consumes the state of the directory from where it's derived and we can't call it twice: https://github.com/ipfs/go-ipfs-files/blob/88b4692b4642719bb8459a966f4b9a3da57c6e2d/multipartfile.go#L218-L221 (I could try to repackage what...

Blocked on https://github.com/ipfs/go-ipfs-files/issues/53.

We can't easily fix https://github.com/ipfs/go-ipfs-files/issues/53 so working around it here.

@lidel Unified loops to use the iterator only once.

@BigLep I'm confused on exactly what those changes should be. That's why I requested an issue to be created with the scoped changes needed to land this PR (if those...

@BigLep Note that `ipfs log tail` can be fixed pretty easily, independent of the entire "switch the whole code base to log@v2". It's just the file diff https://github.com/ipfs/go-ipfs/pull/8765/files#diff-8ecc58f41eaa3971752dc974dd21fd9c1ecfdac1c15e9e9c40dc6fa4283a8d4e. That can...

Deploy is failing probably because I should have updated some index after changing file names, I'll leave that to you @yiannisbot.

For me, the most confusing part is that I don't find the `Prefix` in the [CID](https://github.com/ipld/cid/search?q=prefix) specification so I don't know what to expect of this structure. From the code...

FWIW, the JS implementation of the [`prefix`](https://github.com/ipld/js-cid/commit/7dae38e) is worth looking at, where it is just a derivation (as a function, not a separate structure) of the CID.