Lucas Molas

Results 112 comments of Lucas Molas

And particularly how are we enforcing (or approaching) the "simultaneous" part of the test.

Ok, but how do you define concurrent in practice?

What I'm seeing here is the first dial timeouting before the second one has a chance to hit and I'm trying to figure out how to better guarantee that simultaneity.

> It's the invariant that two concurrent dials to the same addresses are joined. This extends to 'same peer' also right? (This might be implicit in what you just stated,...

Looking into this. After changes from https://github.com/libp2p/go-libp2p/pull/1354 I can no longer reproduce the above but get this error instead: ``` === RUN TestMultiplePeers decay_test.go:151: Error: Condition never satisfied Test: TestMultiplePeers...

@marten-seemann I think we can close this issue. I haven't been able to reproduce the error and with a controlled number of elapsed decaying ticks (through the mock clock of...

Leaving as a draft for now as I'm missing the target for `id[2]` of 40. It doesn't match the expected value of adding the bumps and subtracting the decays as...

@raulk Was that the math you had in mind when you were writing the tests or am I missing something?

Seems I'm not correctly interpreting the logic of the negative case in this more linearized version of the test: https://github.com/libp2p/go-libp2p/blob/66cd76df22e8f50717da0cfd1765f90d4d58f1e0/p2p/net/connmgr/decay.go#L191-L202 @raulk Would it be ok to keep this test with...