Lucas Molas
Lucas Molas
@ajnavarro Yes, but where are those threads created that manipulate the same shard? By that criteria anything that doesn't have a lock has a race condition, but it depends on...
Working on some special case variant that will at least cover the basic `object diff` use case.
No experience with this so no preference. From the [library recommendations](http://jsonpatch.com/#go) in jsonpatch that seems the more maintained one so let's go with that. Ideally the library used to perform...
Per Lidel's request in https://github.com/ipfs/go-merkledag/pull/82#discussion_r796695869 going with diffing JSON output instead of implementing a specialized DAG-PB diff logic.
It seems that library doesn't create patches/diffs, just applies them or checks for equality, trying https://github.com/mattbaird/jsonpatch as a first attempt.
> start with shallow diff between JSON objects following IPLD Data Model Agreed; that's what I'll provide. A basic comparison of JSON output from `dag get`, after that is up...
@lidel https://github.com/ipfs/go-ipfs/pull/8711
> it looks like it can create jsonmergepatch (rfc7396)... but not jsonpatch (rfc6901). :( I think the latter is what we want. Sorry @warpfork, I see that you were already...
I can't reproduce your error. Let's just wait on @lidel's review on this one.
I'm now hitting @Jorropo's error `Error: expected a file argument`. Not sure if this is related to the rebase, but in any case I'll delve deeper into the `add` command.