chore: update to go-log@v2
Need review and help in the flagged items in core/corehttp/logs.go.
Closes https://github.com/ipfs/go-ipfs/issues/8753. Closes #9245
2022-04-07: we need to see if this has been superseded by go-libp2p work.
@schomatis you should also rebase on master too, a few things have changed, but AFAIK not the main blocking point.
@schomatis : are you going to make the corresponding change/improvement in go-lobv2?
@BigLep I'm confused on exactly what those changes should be. That's why I requested an issue to be created with the scoped changes needed to land this PR (if those are indeed a blocker here; I didn't completely understood the feedback here).
Ok, I'll open an issue on go-log
2022-04-26 conversation:
- For 0.13: do nothing (in the release notes for 0.13, "if you were using log-tail for certain things, you'll need to look at the daemon input. Previously we had some output in daemon logs and some log-tail.")
- For 0.14 we're going to make log-tail work as desired.
@BigLep Note that ipfs log tail can be fixed pretty easily, independent of the entire "switch the whole code base to log@v2". It's just the file diff https://github.com/ipfs/go-ipfs/pull/8765/files#diff-8ecc58f41eaa3971752dc974dd21fd9c1ecfdac1c15e9e9c40dc6fa4283a8d4e.
That can land in the next release if desired.
@Jorropo : is there an issue in https://github.com/ipfs/go-log to improve things there?