go-libp2p icon indicating copy to clipboard operation
go-libp2p copied to clipboard

Published 20 hours ago • verified publisher icon libp2p

connmgr: flaky TestMultiplePeers

Open marten-seemann opened this issue 3 years ago • 3 comments 

  === RUN   TestMultiplePeers
      decay_test.go:220: wrong value; expected = 2670; got = 2671
  --- FAIL: TestMultiplePeers (1.08s)

marten-seemann avatar Feb 07 '22 08:02 marten-seemann

Assigning myself.

schomatis avatar Jun 23 '22 23:06 schomatis

Looking into this. After changes from https://github.com/libp2p/go-libp2p/pull/1354 I can no longer reproduce the above but get this error instead:

=== RUN   TestMultiplePeers
    decay_test.go:151: 
          Error:        Condition never satisfied
          Test:         TestMultiplePeers
--- FAIL: TestMultiplePeers (0.65s)

So will start there with an eye on the 2670 check also.

(edit: that actually is the 2670 check, my current error might just be a timeout in my local enviroment)

schomatis avatar Jul 05 '22 23:07 schomatis

@marten-seemann I think we can close this issue.

I haven't been able to reproduce the error and with a controlled number of elapsed decaying ticks (through the mock clock of https://github.com/libp2p/go-libp2p/pull/1354) this shouldn't happen again, and if it does it would no longer be a flake but an actual bug (this will be made even more explicit now with https://github.com/libp2p/go-libp2p/pull/1642).

schomatis avatar Jul 07 '22 15:07 schomatis