Johannes Schmölder comments

Results 112 comments of


                                            Johannes Schmölder

Include Doxygen build

Did you use the updated command? ``` sphinx-multiversion ./ ./build/ -D 'exhale_args.containmentFolder=${sourcedir}/api' ```

Hmm, it does work for me and I got the command from the [sphinx-multiversion documentation](https://holzhaus.github.io/sphinx-multiversion/master/configuration.html#overriding-configuration-variables). Maybe it's a Windows issue? @ronald-jaepel could you try to reproduce this?

Include Doxygen build

Thanks! Unfortunately, it doesn't run on Linux without the quotes so I added a comment in the README.

Include Doxygen build

Sorry to ask, but what are the next steps?

Update to latest SUNDIALS version

Automatic code formatting using pre-commit and clang-format

I like this! :)

Use a piecewise cubic polynomial for charateristic charge in GIEX adsorption model

Thanks for putting this together! I pulled and it compiled fine. However, if I try to run it, it does not seem to read the parameters properly. ``` ERROR: GIEX_NU...

Use a piecewise cubic polynomial for charateristic charge in GIEX adsorption model

> > Maybe it's because of the 'skipConfig' flag? > > Indeed, that was the case. The validation code ran before the custom parameter reading code. Lucky guess! ^^ >...

Use a piecewise cubic polynomial for charateristic charge in GIEX adsorption model

I noticed that the total resin capacity seems to be exceeded sometimes. [giex_check_lambda.zip](https://github.com/modsim/CADET/files/6862502/giex_check_lambda.zip) For example, if you check `cadet.root.output.solution.unit_003.solution_solid[-1,0,:]` (last solution time, first column cell, all components), it returns ```...

Use a piecewise cubic polynomial for charateristic charge in GIEX adsorption model

I think there is an issue with the variable names here: > ```python > con = nu_const[n_pieces * i:n_pieces*(i+1)] > lin = nu_const[n_pieces * i:n_pieces*(i+1)] > quad = nu_const[n_pieces *...