Johannes Schmölder
Johannes Schmölder
@WFlynnZ could you please give an update on the current status of this project. - What's missing? - Do you have an estimate when we can merge a first version...
I added some comments to the code that need to be addressed before merging. Also, I couldn't find unit tests for the crystallization module; please add some. Same goes for...
> I guess we can merge it when the ms is accepted? It would be even better to merge before publication because then you can simply refer to the CADET...
> Isn't the ms the document? I assume you mean the manuscript? > What is the unit test you mentioned? A unit test is some piece of code that is...
Hey @WFlynnZ we're currently cleaning up our project management pipeline and were wondering if you could update us on the current status of the crystallization module. What's missing and when...
It would be great if we could finalize this PR s.t. we can include it in v5.0.0 of CADET. What's currently blocking the merge?
@lieres do you have any thoughts on this?
As discussed, the specs should live in another, separate repo. Progress will be tracked here: https://github.com/cadet/CADET-Specification/issues/1
This should work now. It's not pretty but that's more of a long term project, I'd say. Please verify that it builds locally!
please try again.