Johannes Schmölder
Johannes Schmölder
This PR is ready to be reviewed! :partying_face: We test all unit operations using `createLWE` with different combinations of solution recorders (i.e. `split_components=True/False` etc) in [CADET-Python](https://github.com/cadet/CADET-Python/pull/11) and check that the...
Oh yes, it's just a working title because @hannahlanzrath is still checking with her supervisor what to call it.
> I'd prefer setting the sparsity pattern based on the actual exchange matrix structure (i.e., only add non-zeros in the pattern for compartments that actually communicate). We fixed that by...
> > To this end, `setSparsityPattern()` can be called in `configure()` instead of `configureModelDiscretization()`. > > @jazib-hassan-juelich @jayghoshter yesterday, you had a look at the order of calling the various...
sorry, I made a mess while trying to rebase. I will clean up and force push.
We need to make sure to also implement the fix for dynamic flow rates provided in #101.
Hi Hannah, what's the current status on this PR? Please give us a sign when this is ready to merge. Best Johannes
Hi Hannah, sorry for the long silence. If we look at the to-dos, we're only missing a unit test. Maybe we can get this done next Friday during our Core-Dev...
I just realized that this PR didn't contain any documentation or interface specification. In future, we should make sure to add that before merging. Or at least create a separate...
Excellent idea! Note, that @sleweke already provided a [PTC implementation](https://github.com/fau-advanced-separations/CADET-Process/blob/master/CADETProcess/equilibria/ptc.py) in CADET-Process that I use to pre-process some complex scenarios.