Johannes Schmölder
Johannes Schmölder
Yes. I forgot about doxygen. Also, the copyright should now be updated via #170.
General question, are we really implementing a [Frustum Geometry](https://en.wikipedia.org/wiki/Frustum) or rather a [Spherical Sector](https://en.wikipedia.org/wiki/Spherical_sector). It seems that a frustum has flat surfaces, which is also what would be used in...
> make the velocity/cross section area/flow rate interface unique. Option1: remove velocity field, require cross_section/radius and add flow direction field. I would vote for removing the velocity field. While this...
I agree that backward compatibility should be maintained where possible. But we could still remove it from the "official" interface. By the way, is it even possible to still use...
I agree but that's not for me to decide. 😅
We have a (somewhat up-to-date) guide in the Forum: https://forum.cadet-web.de/t/how-to-make-a-new-cadet-release/401
As discussed, I would recommend separating the fields into: - `unit_type`: `column` (or even maybe even `chromatography`) - `geometry`: `axial` | `radial` | `frustum` - `dimensionality`: `0D` | `1D` |...
Unfortunately, rebasing was not possible without additional work. Amongst other issues, the PR includes changes to the unit operation models and it's not quite clear yet as to why. I...
Note, for now the PR only includes a `.pre-commit` file. This only performs a very limited number of formatting steps (e.g. removing trailing whitespace). clang-format still would need to be...
PR is probably also a duplicate of #148