Konstantin Scheglov

Results 222 comments of Konstantin Scheglov

It seems that we need to know how the file is referenced, so the kind is better than a separate collection. Maybe somehow else, depends on for what else we...

There were no new changes to the analysis driver as far as I know. So, this is probably something that exists for long time. And my consistent suspicion is that...

Well, if you are OK with inconsistent results, we could do something to relax the analyzer. IIRC, you use `package:analyzer/src/clients/build_resolvers/build_resolvers.dart` to create `AnalysisDriverForPackageBuild`, right? If so, theoretically, we could add...

You need to defined yourself what it means to be equal for types based on elements from different analysis sessions. For example ```dart bool areEqualInterfaceTypes(InterfaceType left, InterfaceType right) { return...

I don't know how you get all these other elements, types, and checkers. Let's consider a specific example. I don't write builder myself, so I will say potentially something wrong....

I'm surprised that there is a need to invoke `driver.changeFile()` when the builder asks for `L''`. If the builder is allowed to access `L''`, then it has always been visible...

FWIW, I like `void foo() incomplete;` body syntax, it is consistent with just `void foo();` as if it were `void foo() abstract;`.

I added some logging to the analyzer, it saw that we don't pass a `MacroSupport` instance when create `AnalysisDriver`. Then I realized that `package:build` goes through a different path than...

> Nice, I did get things working here. I had to also explicitly make the package config file available to the in memory resource provider (and make it also match...