Steve Dignam

Results 174 comments of Steve Dignam

hmm does the issue happen with mypy as well, wonder if something changed

django-stubs is the parent of this fork, what happens if you use django-types with mypy?

this project (django-types), doesn't use a mypy plugin so If you remove that it might work?

yeah stubs will fall behind, I only added things that I've needed when I've need them rather than trying to keep 1:1 with Django for instance, in my django project...

I'd be curious what happens when it's not installed and someone tries to use a Django Postgres specific thing, since we depend on the types: https://github.com/sbdchd/django-types/blob/610f267873cbc2eca8a49434cd0b7a6b323807df/django-stubs/db/backends/utils.pyi#L11

Yeah makes sense! I think we'd need to update the following and basically mark which ignores have been used as we go through the errors: https://github.com/sbdchd/squawk/blob/52fdeca5d5466957cc21be33bf399fc7bd763949/crates/squawk_linter/src/lib.rs#L429-L442

This should be fixed in latest, can you double check it works for you? https://play.squawkhq.com/#code/M4UwLgBMYIZiBbEA7MB9MBLJB7ArpALwQDkArMCQNwBQokANjgMYDWG2I+RpAjJbQBGIAOaZktAMIAlAKIBBACqyIi+QCEAMiswAzCMhyQQAD0zRgEWIIYg0yGEggAKTABMIAVU8BJACIQAHIA8opBnpqaADQQujgATiCYIsho7l6+ASFhgRGaAJS08prK0qoa2lYwNnYOTjTyfgGSwYEAyorS8j6BYQBE1rb2jna6rCAAnn0QNBAQAGLBcj4A4oEQANKyAJoufXGJyanuffkzc3LzsnKBkrJtEPsJSSkY1bbTzn0nZ7MQrRA-LJtMogsEIPJJIofK0-v91p4AAp+JQqEIQqEwwK0Zg4BAITBgKhAA The following passes: ```sql set statement_timeout = '5s'; set lock_timeout = '1s'; begin; CREATE TABLE...

wonder if this rule would also include schema on function definitions: https://www.instantdb.com/essays/pg_upgrade#marked-fn-8

Yeah I think this makes sense to include, I wonder if we need more semantic info, like checking that `hash` refers to the actual postgres `hash` or if going off...

Yeah I've been thinking about how we should integrate these database stats, I think an script to dump the necessary stats to a static file is what I'm leaning towards...