Steve Dignam
Steve Dignam
This is somewhat tricky to implement as there isn't an easy way to compare the two AST trees to ensure they are equivalent rel: https://github.com/sbdchd/flake8-pie/pull/84/files#diff-2cef682e5cbc4dc317854e5887d9f23ac9a3421cbb53a95f621808bcc8165244R8
see: https://github.com/sbdchd/flake8-pie/issues/77#issuecomment-836779943
This isn't really safe without type information: ```python class Foo: def __getitem__(self, key): print(key) Foo()[:10] # slice(None, 10, None) Foo()[0:10] # slice(0, 10, None) ```
Yeah we ran into this as well. Turns out the heuristic for checking whether a f-string is necessary wasn't as simple as originally thought.
I think removing the rule would be easier / simpler than trying to fix the heuristic
I've removed this rule in the latest version https://pypi.org/project/flake8-pie/0.5.0/ edit: feel free to let me know if there are any problems
The test is hanging, something to do with redis: ``` + ./.venv/bin/pytest kodiak/test_queue.py =================================== test session starts =================================== platform darwin -- Python 3.7.13, pytest-6.0.1, py-1.10.0, pluggy-0.13.1 rootdir: /Users/steve/projects/kodiak/bot, configfile: tox.ini...
We could also switch to redis-py which has proper health checks built into the client
ConnectionResetError -> https://docs.python.org/3/library/errno.html#errno.ECONNRESET And ECONNRESET is caused by the server, redis in this case. So we should investigate on the redis host: - ulimit for file descriptors `ulimit -n` -...
Running `trivy` on the latest release I get: ``` 22-07-04T17:59:10.298-0400 INFO Table result includes only package filenames. Use '--format json' option to get the full path to the package file....