Steve Dignam
Steve Dignam
if I understand correctly, the goal is to make: ```sql ALTER TABLE "recipe" ADD CONSTRAINT view_count_not_null CHECK ("view_count" IS NOT NULL) NOT VALID; ALTER TABLE "recipe" VALIDATE CONSTRAINT view_count_not_null; ALTER...
> Another idea: we could build a plug-in system atop https://github.com/ast-grep/ast-grep. This would allow users to express lint rules in YAML or via a simple DSL. something like this would...
Good question, I was going to say because we have some non-optional keyword args following optional keyword args, but that doesn't seem to be the case. I think the `*,`...
oh pyright is angry in CI, maybe it needs an update?
Looks good! Linter is a little angry: ``` 18 All done! ✨ 🍰 ✨ [19](https://github.com/sbdchd/django-types/actions/runs/5488440137/jobs/10001296563?pr=177#step:8:20) 3 files reformatted, 699 files left unchanged. [20](https://github.com/sbdchd/django-types/actions/runs/5488440137/jobs/10001296563?pr=177#step:8:21) + ./.venv/bin/isort tests typings [21](https://github.com/sbdchd/django-types/actions/runs/5488440137/jobs/10001296563?pr=177#step:8:22) + ./.venv/bin/mypy...
Hmm seems mypy is mad, maybe `# type: ignore[misc]` for now?
Oh that's a tricky one to type. Currently the annotations have it typed as returning `Any`: https://github.com/sbdchd/django-types/blob/a2de4090d2f8a2f52fa1ca489c2c063b19c659e5/typings/django/db/models/manager.pyi#L22-L25 using the django docs example: ```python class CustomManager(models.Manager): def manager_only_method(self): return class CustomQuerySet(models.QuerySet):...
I have `filetype detect` trigger inside my config file so that I can reload the config without having to restart Vim; however, this results in godown not being able to...
still an issue
Pretty sure we use `__new__` instead so that we can make both pyright and mypy happy: https://cs.github.com/sbdchd/django-types/blob/8b5f4bcbfa3b3ee7663f2b502490f1d4a7021d98/django-stubs/db/models/fields/__init__.pyi?q=CharField#L687 might be worth revisiting if that's still necessary -- I can't remember which...