Steve Dignam

Results 174 comments of Steve Dignam

Ah yeah that's missing When creating this project I basically only wrote types for the parts I needed -- probably should have used stub-gen https://mypy.readthedocs.io/en/stable/stubgen.html

Oh at runtime, yeah I need to update the docs, you'll need to monkey patch Task to accept a generic argument: ```python Task.__class_getitem__ = classmethod(lambda cls, *args, **kwargs: cls) #...

Another option is to do something like: ```python from typing import TYPE_CHECKING if TYPE_CHECKING: class AnyTask[Any, Any]: ... else: AnyTask = Task from celery.app.task import Task from typing import Any...

Yeah that’s possible but then we’d need to have a second package and it’s only a couple lines of code to copy

Basically these stubs were started before typeshed releases were disconnected from type checker releases, so by having the types in their own package, it is/was easier to get updates through

Currently these types are pretty incomplete so they would need to be fleshed out more before submission

hmm, II'm not sure why that is happening If I run `pip freeze` inside the virtual env I get: ``` appdirs==1.4.4 appnope==0.1.2 argh==0.26.2 astpretty==2.1.0 atomicwrites==1.4.0 attrs==20.3.0 backcall==0.2.0 black==18.9b0 bleach==3.3.0 certifi==2020.12.5...

Hmm I usually use poetry to manage my virtual envs (although this repo is using a truly ancient version) But if you create a virtual env and install all the...

Another thing to check for: ```python logging.info("foo %s%", "bar") # raises ValueError: incomplete format log.warning("foo bar buzz", 10) # TypeError: not all arguments converted during string formatting # Message: 'foo...