Sergey Torgashov

Results 265 comments of Sergey Torgashov

I'd like to clarify one thing: in **sbt-tpolecat** there's a notion of Dev/CI/Release compiler option sets, whereas seems that **sbt-typelevel** does not have such a notions (with an exeption of...

On **temurin11** it fails as well: ``` $ java -version openjdk version "11.0.15" 2022-04-19 OpenJDK Runtime Environment Temurin-11.0.15+10 (build 11.0.15+10) OpenJDK 64-Bit Server VM Temurin-11.0.15+10 (build 11.0.15+10, mixed mode) ```

And which JDK is it currently working on? Did you have it succeeding on any JVM locally?

Sorry if I'm not getting it correctly: the suggestion is to improve scala-steward for that, correct? Or is there something left to be addressed on the sbt-typelevel level?

Yeah, I like that idea too. Seems similar to the discussion we have around generalization of `group`-alike methods in other PRs – instead of hardcoding output types we could try...

I wonder if it is possible to change a location of boilerplate source files too. Because currently it is just `/project/` which does not seem to be obvious and easy...

The PR is created as "Draft" because this work was done quite a long ago and I just want to make sure I didn't lose something after lots of merges...

I've made a deep inhale and re-reviewed the changes here. I would say they look good to me and seems all the tests and Mima checks are happy as well....

I think that all the concerns have been addressed here. Could you take one more look please?

@armanbilge I added direct `NonEmptyAlternativeLaws` tests for `IRWST` type. But besides that I could not refrain from cleaning that file up a little bit: 1. `class ReaderWriterStateTSuite` renamed to `IndexedReaderWriterStateTSuite`...