Sergey Torgashov

Results 265 comments of Sergey Torgashov

I am not sure about bringing `BigInt` into this hierarchy... It would be especially weird to see `BigInt` when we're working with some relatively simple type like `Short`.

Could you elaborate a bit more please on how to reproduce this?

Looks like this can be closed as completed in RC3.

I dare to suggest that this my PR could be useful for the migration to the sbt-typelevel plugin, because it has scalafmt enabled by default: #1989.

Hi @Duhemm ! Thank you for the ping. I'm really sorry that it takes so much time to review your PR. Honestly, I made a couple of attempts to look...

@RustedBones thank you for the contribution! May I clarify one question please? What is the reasoning for adding the following implicit conversions: ```scala implicit def wrapArrayList[T](xs: ArrayList[T]): Traversable[T] = xs.asScala...

Oh, I see now, thank you for the clarification! To be honest, that constraint looks quite odd to me. It does not seem to be used in the code for...

Yes, I see what are you talking about. Perhaps, it was the idea behind that decision indeed. However, I personally don't feel it should be done that way: `shrinkContainer` takes...

> think this statement is not correct >> shrinkContainer takes its own Buildable implicit which itself does not require the C => Traversable evidence to exist. Actually I mean that...

@mrdziuban thank you for the ping. To be honest, I forgot about your PR a little bit, sorry about that. I'm trying to wrap my head around the proposed changes,...