Sergey Torgashov

Results 265 comments of Sergey Torgashov

@jatcwang , I've actualized the PR: rebased onto **main**, updated scalafmt version, re-applied formattings and **.git-blame-ignore-revs** Let me know if you have any suggestions/concerns please. Thank you!

@jatcwang sure, np. Let me know please when I should update this PR to synchronize it with the upstream. Also I think that once this PR gets settled in main,...

The PR is updated: - Bump scalafmt up to v3.8.2 - Reformat with the new version - add scalafmt checks to the CI workflow

@jatcwang , turns out the new Scalafmt version (3.8.2) started reformatting in multiline strings a little more aggressively. It resulted in these changes: https://github.com/tpolecat/doobie/pull/1989/commits/d8c3d1ceb74d10899fca7ea7ecdb6b8156a1d9ca The changes don't break the build...

Looks like the CI failed because `freeGen2` command updates auto-generated sources... The problem here is that if I apply `scalafmt` to auto-generated sources and commit the changes (as it is...

The PR is updated: 1. Disable formatting in auto-generated files via adding `// format: off` to the beginning of each file. 2. Reformat again to apply the changes.

@jatcwang, hopefully, the CI issue has been resolved now.

@jatcwang , just in case – in regards to the auto-generated sources: Perhaps, in makes sense to bring in an approach that is used in Cats for that: https://github.com/typelevel/cats/blob/dd891334505b35e010a12da254924811de838c85/build.sbt#L114 I.e....

You can adjust `Transactor` instance for your needs as described in the docs: https://tpolecat.github.io/doobie/docs/14-Managing-Connections.html#customizing-transactors So in your case you may come up with something like that: ```scala val xa1 =...

I think it is related to (or maybe duplicates) #772.