Samuel Karp

Results 341 comments of Samuel Karp

> Would it be possible to fix the first commit to revert the imports that moved to reduce code-churn a bit? (I'm guessing it git got confused when cherry-picking the...

Can you [sign off your commit](https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work)?

> Update golanci/golangci-lint package from v1.48.0 to v1.50.1. This doesn't appear in the diff.

> [samuelkarp](https://github.com/samuelkarp) force-pushed the buildsys-go-modules branch from 65bd339 to a7b439a Added `.gitignore` files to the packages for the `src/` directory that gets created during build.

@bcressey Thanks for the detailed review here! I no longer work for Amazon and am not currently in a position to dedicate my own personal time or resources to moving...

I don't know that I have enough information to really answer your question, but I'll ask a few questions/try to write down some observations that I think might help you...

> They would need to launch replacement AMIs because we do not have https://github.com/bottlerocket-os/bottlerocket/issues/1261 So if that's the case, the eventual sunsetting of the aws-ecs-1 variant might leave customers who've...

Hi @samjo-nyang, thanks for opening this issue. Is the Kubelet credential provider the only feature gate you're looking to enable or are there others that you're interested in as well?

Hey @samjo-nyang, thanks for clarifying! We've discussed this and at this time we're not planning to add arbitrary feature-gates; Bottlerocket's validated settings API is one of the mechanisms we believe...