Abdul Malik Ikhsan
Abdul Malik Ikhsan
It seems I can do with: ```php if (isset($oldTokens[$attrGroup->getEndTokenPos() + 1]) && ! str_contains((string) $oldTokens[$attrGroup->getEndTokenPos() + 1], "\n")) { $print = $this->betterStandardPrinter->print($attrGroup); $attributesAsComments[] = new Comment($print); } ``` then remove...
I found that add new line to next token seems works: ```php if (isset($oldTokens[$attrGroup->getEndTokenPos() + 1]) && ! str_contains((string) $oldTokens[$attrGroup->getEndTokenPos() + 1], "\n")) { // add new line $oldTokens[$attrGroup->getEndTokenPos() +...
Ready to merge 👍
the verification of fully qualified already checked before check on line 114, so I think that's safe
I think that need to be feature request for nikic/php-parser
I created downgrade PR rule first: - https://github.com/rectorphp/rector-downgrade-php/pull/253 to allow code to be downgraded on the first place.
The no parenthesis syntax is not only on method call, but also static call, property fetch, etc, per rfc https://wiki.php.net/rfc/new_without_parentheses which downgrade need to be exists first so full feature...
probably add optional flag?, eg: ```php public function injectRawData(array $data, bool $mergeToExistingAttributes = false) ```
Thank you @julienfastre
@TomasVotruba this is why I was suggesting to remove this rule: - https://github.com/rectorphp/rector-phpunit/pull/490 that you closed, as you want this to upgrade phpunit 9 to 10, so we add special...