CodeIgniter4 icon indicating copy to clipboard operation
CodeIgniter4 copied to clipboard

refactor: fix PHPStan errors

Open pawelkg opened this issue 1 year ago • 4 comments

Description Fix errors from phpstan-baseline.php

Checklist:

  • [x] Securely signed commits
  • [ ] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [ ] Unit testing, with >80% coverage
  • [ ] User guide updated
  • [ ] Conforms to style guide

pawelkg avatar Aug 15 '24 22:08 pawelkg

please create multiple PRs for per-directory basis to make easier to review, also, better fix per error identifier instead of try to fix everything, then you can rebase when one of PRs merged.

samsonasik avatar Aug 16 '24 04:08 samsonasik

Sorry, we cannot review too big PRs like this (changes: +413 −778). Your one commit is too big and having a lot of different changes, and the commit messages do not make sense like "fix another PHPUnit DatabaseLive errors part2". One commit should be for one change, and the commit message should be more meaningful.

Now we don't have detailed rules on commits and its messages. But atomic commit is recommended. Keep your commits atomic. One commit for one change.

Read carefully: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#committing

And could you please make multiple very small PRs, and change (fix) one thing in one PR?

kenjis avatar Aug 16 '24 09:08 kenjis

Ok. I will prepare separate PRs with smaller, internally related scopes.

pawelkg avatar Aug 16 '24 10:08 pawelkg

:wave: Hi, @pawelkg!

We detected conflicts in your PR against the base branch :speak_no_evil:
You may want to sync :arrows_counterclockwise: your branch with upstream!

Ref: Syncing Your Branch

github-actions[bot] avatar Aug 29 '24 01:08 github-actions[bot]