refactor: fix PHPStan errors
Description Fix errors from phpstan-baseline.php
Checklist:
- [x] Securely signed commits
- [ ] Component(s) with PHPDoc blocks, only if necessary or adds value
- [ ] Unit testing, with >80% coverage
- [ ] User guide updated
- [ ] Conforms to style guide
please create multiple PRs for per-directory basis to make easier to review, also, better fix per error identifier instead of try to fix everything, then you can rebase when one of PRs merged.
Sorry, we cannot review too big PRs like this (changes: +413 −778). Your one commit is too big and having a lot of different changes, and the commit messages do not make sense like "fix another PHPUnit DatabaseLive errors part2". One commit should be for one change, and the commit message should be more meaningful.
Now we don't have detailed rules on commits and its messages. But atomic commit is recommended. Keep your commits atomic. One commit for one change.
Read carefully: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#committing
And could you please make multiple very small PRs, and change (fix) one thing in one PR?
Ok. I will prepare separate PRs with smaller, internally related scopes.
:wave: Hi, @pawelkg!
We detected conflicts in your PR against the base branch :speak_no_evil:
You may want to sync :arrows_counterclockwise: your branch with upstream!
Ref: Syncing Your Branch