Alexander Makarov
Alexander Makarov
@MarkoNV would you please explain the motivation of the PR?
Test issues aren't related to this PR.
Changing authKey of a user is meant to invalidate sessions including authentication cookies. But if the user himself initiates it then he's unlikely want to be logged out in the...
Hmm. Got it. How would you solve the problem? We may potentially switch from patching to https://github.com/Yoast/PHPUnit-Polyfills/ but that would require some work to ensure tests have all the traits...
> Or maybe just switch to a phpunit version based on the php version used? Not sure of that's possible though. Only if we'll drop support for many PHP versions...
> using polyfils instead of patching does sound better (and then you also might not need to maintain these patches yourself?) Yes if that library will be maintained further.
Well, with some additional tests I don't mind having it.
Do you have time for a pull request?
Interesting. 1. Adjust code. 2. Add docs. 3. Add CHANGELOG line. Do you have some time for a pull request?
@yiisoft/reviewers what do you think?