Alexander Makarov comments

Results 1745 comments of


                                            Alexander Makarov

Allow to pass closure as logger configuration option

@kminek we can still solve it but with keeping the interface.

Rename ListenerCollection::add

That would be a BC-breaking change.

Allow parent fields

Сделаете отдельным pull request тестов на [phpbench](https://github.com/phpbench/phpbench)?

Allow parent fields

Там всё не очень сложно. Штука хорошая, советую освоить, пригодится.

💡 Render exception class description

Could be useful. Good idea 👍

Make HTML page customizable

Can't you do it with https://github.com/yiisoft/error-handler/blob/master/src/Renderer/HtmlRenderer.php#L106?

Use pjax without making a server request

``` javascript // disable and then re-enable to make sure our handler is before PJAX's $.pjax.disable(); $(window).on('popstate', function (e) { if (!needPjax()) { $.pjax.disable(); e.stopImmediatePropagation(); // do your non-PJAX stuff...

Use pjax without making a server request

But overall I'd love to be able to prevent fragment replacing if `pjax:popstate` handler returns `false` or prevents default.

onMenuScrollToBottom not fired on desktop when the scrollbar is mouse-dragged to the bottom

We're affected by it as well. @JedWatson is it possible to review/merge https://github.com/JedWatson/react-select/pull/4970?