Alexander Makarov comments

Results 1745 comments of


                                            Alexander Makarov

Fixtures does't work as they should

``` array_merge(): Argument #2 is not an array ``` Which code produces the exception?

Fixtures does't work as they should

Do you have a fixture data file? https://github.com/yiisoft/yii2/blob/master/framework/test/FixtureTrait.php#L145 ```php $this->_fixtures = $this->createFixtures(array_merge($this->globalFixtures(), $this->fixtures())); ``` Produces: ``` [yii\base\ErrorException] array_merge(): Argument #2 is not an array #1 /var/www/edrid/vendor/yiisoft/yii2/test/FixtureTrait.php:145 ``` That means that...

Fixtures does't work as they should

Are you sure your fixture data is loaded properly?

on AfterSend event blocks sendig the view

@kamarton so that's buffering that's not Yii-related, right?

on AfterSend event blocks sendig the view

I think we can do it as well.

->cache(true)->sum('attribute') in mysql doesn't work.

Is that MySQL specific? Does it depend on how cache is configured?

yii2/db/Schema uses getSlavePdo() to quote a value - which errors when fallbackToMaster is set to false

@developedsoftware the logic here is: 1. Always try to use replica database for quoting since using primary for that isn't great for performance. 2. If it is ODBC, do not...

yii2/db/Schema uses getSlavePdo() to quote a value - which errors when fallbackToMaster is set to false

The pull request looks weird to me. 1. [`$fallbackToMaster` is true by default for connection](https://github.com/yiisoft/yii2/blob/b77caaa0b20a43a942e3ff217844c7c12f4b0572/framework/db/Connection.php#L1050). 2. [You pass `true` explicitly](https://github.com/yiisoft/yii2/pull/19816/files) which matches the default so technically exactly the same value...

yii2/db/Schema uses getSlavePdo() to quote a value - which errors when fallbackToMaster is set to false

Alright. That's rare case but I see now how it could be possible. Thanks for explaining.

Fix login cookie destroyed after authKey change (#19621)

The change is controversial. The change of auth key should invalidate sessions.