Alexander Makarov comments

Results 1745 comments of


                                            Alexander Makarov

Added PHPDoc type hinting for request and response properties of yii\base\Controller derived classes

https://github.com/yiisoft/yii2/blob/master/build/controllers/PhpDocController.php this one. It is running for years on each release.

#20055 Fix X-Pagination-Total-Count is always 0

@lav45 how about https://github.com/yiisoft/yii2/pull/20060?

#20055 Fix X-Pagination-Total-Count is always 0

Would you please add a line for CHANGELOG?

#20055 Fix X-Pagination-Total-Count is always 0

:+1:

Default expression is not loaded into ColumnSchema

Doesn't look good. Do you have a time for a fix?

Default expression is not loaded into ColumnSchema

@SOHELAHMED7 if breaking change is unavoidable, feel free to do it. But it's better to avoid it.

Resolve: Load Default expression into ColumnSchema class for MySQL and Mariadb

Need better review. Moving to next milestone. @yiisoft/reviewers, @cebe would you please take a look?

Check the column value in batch insert for SQLite prior to 3.7.11 ver…

Would you please add tests and CHANGELOG for the change? It's currently not clear what does it fix. Tests would prevent it being broken again in the future.

Count query with group in class extends \yii\db\Query

@rhertogh, @bizley is there something to do for this one besides unit test fix that was done?

Count query with group in class extends \yii\db\Query

OK. @bizley do you have time for a pull request? I plan to release soon.