yii2
yii2 copied to clipboard
Check the column value in batch insert for SQLite prior to 3.7.11 ver…
…sion
| Q | A |
|---|---|
| Is bugfix? | ✔️/❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues |
PR Summary
-
Improved Error Handling in 'batchInsert' method A new condition was inserted into the
batchInsertmethod within the fileQueryBuilder.php. This addition primarily reduces the chances of encountering an error when a specific column does not exist within our dataset. This enhancement makes our method more robust and less likely to fail, smoothing out the overall operation of the system. -
Implemented Correct Typecasting Following the successful checking of requirements, the value is then accurately typecasted using a
dbTypecastfunction. This change enhances the data integrity by ensuring that the column values are stored in the correct format. This is a crucial step in maintaining our database's reliability, making our data dealings much more efficient and precise.
Codecov Report
Patch and project coverage have no change.
Comparison is base (
4c0a00f) 48.91% compared to head (36ae6b0) 48.91%.
Additional details and impacted files
@@ Coverage Diff @@
## master #19937 +/- ##
=======================================
Coverage 48.91% 48.91%
=======================================
Files 445 445
Lines 42810 42810
=======================================
Hits 20941 20941
Misses 21869 21869
| Files Changed | Coverage Δ | |
|---|---|---|
| framework/db/sqlite/QueryBuilder.php | 41.66% <0.00%> (ø) |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Would you please add tests and CHANGELOG for the change? It's currently not clear what does it fix. Tests would prevent it being broken again in the future.
Hi, any update on this PR. @inisic
Thks.