Sam Coveney comments

Results 86 comments of


                                            Sam Coveney

Issue with coverage and numpy.min

Since downgrading to fix the issue, I have moved on. I had a very hard time isolating the bug. But the fact that downgrading (as explained above) fixed the issue,...

Added SDF to render Super quadrics

What's the progress on this? It would be a very nice addition, are there plans to finish this PR?

Added SDF to render Super quadrics

Thanks for the update @guaje let me know if I can do anything else to help

[WIP] Registration public API for multi-slice 2D data

> Hi @samcoveney > > > But I would like some feedback please. To use, simply provide "slice_index" argument and the return values should be registered 2D data. > >...

[WIP] Registration public API for multi-slice 2D data

Tests are passing on my system, are they failing here for reasons not related to my PR?

[WIP] Registration public API for multi-slice 2D data

Hi @skoudoro thanks for taking a look. Open cardiac MRI datasets (for DWI) are hard to come by, which is why I showed the idea using slices of brain data....

[WIP] Registration public API for multi-slice 2D data

I've not heard back on this, but I think I will modify the code to take out the `slice_index` argument - if the user provides data with a spatial dimension...

prompt_toolkit version for pyinquirer not compatible with ipython

Exactly the same problem here

[RF] fix dki mask for nlls

Hi @skoudoro sorry about my tardy respone, let me look now

[RF] fix dki mask for nlls

I think this is going to conflict with #3078 because of the additional returns of S0 that I have coded in. It wouldn't be too difficult to rebase this PR...