Sam Coveney
Sam Coveney
Just got back from being way, am on it now. Sorry for missing the other tests
Completely rewrote it, in style of dti.py, and fixed the pep8 issues. For the record, it was a bad idea to write dki.py without the ability to save the S0...
Done and done. And I mean done. edit: okay, _now_ it's done edit 2: fixed keyword issue, in preparation for keyword overhaul
Do you know of a way to check this using some tool? Would make the transition easier
Also, as in my recent issue #2655 (which you mention), there seems to be other additional errors related to estimation of the noise threshold. I have a fairly good understanding...
I should also point out that if all pixels are used (as they are here), with the current implementation being that pixels are samples, then N > P (number of...
so this sounds like a relatively simple fix... probably not urgent, but I'll try to look into it soon
@RafaelNH I will take a look at #3151 asap - your PR should be merged first and I will follow later with rebase if needed (not seeing much clash at...
I'll try to get tests etc done in the meantime
Thanks for the review @RafaelNH - I appreciate getting some heads up about the overall structure, if okay? You are right, that a tutorial and some tests will help. If...