samba-operator

samba-operator copied to clipboard

need to check if calls should use SetOwnerReference

4

Currently we use SetControllerReference all over the place, but this may not be the best choice.

phlogistonjohn

Run integration tests in OpenShift

2

gd

updating SmbdContainerImage and ServiceAccountName via environment does not change the share's deployment's image

2

This is on version `v0.2`. ``` > oc logs -n samba-operator-system deploy/samba-operator-controller-manager 2022-06-15T09:33:03.716Z INFO setup loaded configuration successfully {"config": {"SmbdContainerImage":"quay.io/samba.org/samba-server:v0.2","SmbdMetricsContainerImage":"qu ay.io/samba.org/samba-metrics:v0.2","SvcWatchContainerImage":"quay.io/samba.org/svcwatch:v0.2","SmbdContainerName":"samba","WinbindContainerName":"wb","WorkingNamespace":"samba-operator-syst em","SambaDebugLevel":"","StatePVCSize":"1Gi","ClusterSupport":"","SmbServicePort":445,"SmbdPort":445,"ServiceAccountName":"samba","MetricsExporterMode":"disabled","PodName":"samba-operator- controller-manager-7486c6dcf5-zq7w7","PodNamespace":"samba-operator-system","PodIP":"172.20.11.77"}} [...] 2022-06-15T09:33:26.516Z INFO controllers.SmbShare Updating state for...

ibotty

update share's container image when new version is released

1

It would be great to automatically manage the container image updates. On OpenShift, it could use imagestreams and triggers. But that's hardly a general option.

ibotty

samba-operator-controller-manager deployment on openshift has minimal hardcoded ressource limits

2

`oc edit deployment/samba-operator-controller-manager` and then: ``` resources: limits: cpu: 100m memory: 100Mi requests: cpu: 100m memory: 20Mi ``` the results are Out of Memory fails. So i changed it manually...

turricum

Domain controller CRD?

1

Wondering if any design docs have been made for a DC CRD

nwmcsween

We need to add test cases to verify that the metrics container is being created when it should and works (for some value of works). I don't think we need...

phlogistonjohn

This issue is more of a stopgap until proper documentation is written for people searching for that information. I intend to write this up properly. OpenShift's DNS operator does not...

ibotty

RFE: Allow adding sidecar containers to samba shares

3

It would be great to allow adding sidecar containers to the pods serving the samba shares. Our use case is automatically reacting to `inotify` events.

ibotty

Add support for adding annotations to smb share pods

3

Either clone the annotations from the SmbShare resource or have them defined in the CRD

giskou