samba-operator icon indicating copy to clipboard operation
samba-operator copied to clipboard

Add support for adding annotations to smb share pods

Open giskou opened this issue 3 years ago • 3 comments

Either clone the annotations from the SmbShare resource or have them defined in the CRD

giskou avatar Mar 16 '22 09:03 giskou

Hi there, I think that I would be inclined to pass that information to pods via the SmbCommonConfig resource. Would that be suitable for your use case?

Because this is a young project I'm always on the lookout for what others want to do with this operator. I'm curious what specific annotations you're looking to add to get a better sense of what we may add in the CRDs themselves in the future!

Thanks!

phlogistonjohn avatar Mar 16 '22 14:03 phlogistonjohn

Hello,

I wanted to add some velero annotations to backup the smb volumes but I found an alternative to that.

giskou avatar Mar 18 '22 12:03 giskou

That's very interesting, thanks! I do this this a worthwhile point and so I hope you don't mind but I will reopen it.

phlogistonjohn avatar Mar 18 '22 14:03 phlogistonjohn