Sahid Velji
Sahid Velji
In issues #389 and #158, the need to create a V2 of the go-sdk was identified. This topic was also discussed in the biweekly community meeting on Thursday July 3,...
## This PR I still need to fix the tests and also add more doc comments, but I wanted to get alignment from others before going ahead with those changes....
The telemetry package should probably use the OTel semconv package for the consts below. The benefit of doing so is that updates to the semconv would generally require minimal changes...
### Requirements The StateHandler interface defines two functions: Init and Shutdown. https://github.com/open-feature/go-sdk/blob/dd4cf71f8226026a71d51d1edcfd1026c965be15/openfeature/provider.go#L64-L67 There is also a top-level Shutdown function: https://github.com/open-feature/go-sdk/blob/dd4cf71f8226026a71d51d1edcfd1026c965be15/openfeature/openfeature.go#L90-L92 [Section 2.4 of the specification](https://openfeature.dev/specification/sections/providers#24-initialization) says the following (emphasis mine)....
### Requirements I would like to improve the [telemetry](https://github.com/open-feature/go-sdk/blob/main/openfeature/telemetry/telemetry.go) package: - Omit the value from the returned attributes. The value is of type `any` and this results in the loss...
## This PR Add Makefile targets mostly copied from https://github.com/open-telemetry/opentelemetry-go-contrib/blob/bridges/otelslog/v0.10.0/Makefile Note that the lint stage fails, but that will be fixed in a separate follow-up PR. ### Related Issues Fixes...
Many modules in this repo are using outdated dependencies. We should upgrade them all. Some of the modules may require manual intervention due to breaking changes introduced by dependencies. For...
 While changing `interface{}` to `any` is a great modernization step, there's a potential pre-existing issue in this function's implementation. The comparison `val != criteria.Value` on line 37 can cause...
> It doesn't need to be in this PR but we did define more attributes that can be included in the span event. There's already in a [method in the...
Since this repo has multiple Go modules, it can be tedious to keep them all well-managed. For example, `go mod tidy` will need to be run in every module separately....