go-sdk-contrib icon indicating copy to clipboard operation
go-sdk-contrib copied to clipboard
verified publisher icon open-feature

chore: add multi-module compatible Makefile targets

Open sahidvelji opened this issue 7 months ago • 3 comments

This PR

Add Makefile targets mostly copied from https://github.com/open-telemetry/opentelemetry-go-contrib/blob/bridges/otelslog/v0.10.0/Makefile

Note that the lint stage fails, but that will be fixed in a separate follow-up PR.

Related Issues

Fixes #683

Notes

In order to keep my PRs small and manageable, I not did commit the results of running these new Makefile targets, especially because there is some additional work required in order for them to work. For example, some tests are failing and some linter findings need manual intervention.

Follow-up Tasks

How to test

sahidvelji avatar May 31 '25 01:05 sahidvelji

I fixed the merge conflicts - i am really struggeling in my prs with linting etc. so is there anything i can help you with to move forward, and to get linting running again?

aepfli avatar Jul 30 '25 09:07 aepfli

@aepfli To fix linting we'd need to first update to the latest version of golangci-lint, which is v2.3.0 right now. To do that, we first need to make sure that every go.mod has go directive go 1.23.0. See #682 and #712

sahidvelji avatar Jul 31 '25 04:07 sahidvelji

@sahidvelji could you please update this PR so we could merge it.

erka avatar Oct 24 '25 14:10 erka