Abdelhafidh Belalia

Results 422 comments of Abdelhafidh Belalia

Hi, is this still valid? it seems I can't reproduce from my side (1.2.28-1)

When you sign-in you will get a spinner not a blank page, and I think this is the expected behaviour. Not sure what's the problem here

### Proposal ```diff --- a/src/pages/home/report/ReportActionItem.js +++ b/src/pages/home/report/ReportActionItem.js @@ -107,6 +107,13 @@ class ReportActionItem extends Component { if (this.props.draftMessage) { return; } + + const windowSelection = window.getSelection(); + if (!event.target.contains(windowSelection.focusNode))...

@slafortune Not the same issue. I though fixing the first issue will fix this as well but does not seem like it

## Proposal fixing the Firefox-specific behavior to match the behavior in Safari and others ```diff --- a/src/components/PopoverWithMeasuredContent.js +++ b/src/components/PopoverWithMeasuredContent.js @@ -72,9 +72,66 @@ class PopoverWithMeasuredContent extends Component { this.state =...

### Proposal (Updated) ```diff diff --git a/src/components/Modal/BaseModal.js b/src/components/Modal/BaseModal.js index 91b1867a6..7c7c546e3 100644 --- a/src/components/Modal/BaseModal.js +++ b/src/components/Modal/BaseModal.js @@ -26,7 +26,13 @@ class BaseModal extends PureComponent { constructor(props) { super(props); + this.saveSelection =...

### Proposal (Updated 2) ```diff diff --git a/src/components/Modal/BaseModal.js b/src/components/Modal/BaseModal.js index 91b1867a6..f7300cc09 100644 --- a/src/components/Modal/BaseModal.js +++ b/src/components/Modal/BaseModal.js @@ -103,8 +103,8 @@ class BaseModal extends PureComponent { backdropColor={themeColors.modalBackdrop} backdropOpacity={hideBackdrop ? 0 :...

NOT A FULL RCA: The cause is `coverScreen` setting it to true uses the react-native Modal, and this is basically the issue. Not sure what part exactly on the Modal...