Abdelhafidh Belalia

Results 422 comments of Abdelhafidh Belalia

### Proposal (Updated 3) ```diff diff --git a/src/components/Modal/BaseModal.js b/src/components/Modal/BaseModal.js index 91b1867a6..f7300cc09 100644 --- a/src/components/Modal/BaseModal.js +++ b/src/components/Modal/BaseModal.js @@ -103,8 +103,8 @@ class BaseModal extends PureComponent { backdropColor={themeColors.modalBackdrop} backdropOpacity={hideBackdrop ? 0 :...

### Proposal ```diff diff --git a/src/components/Modal/BaseModal.js b/src/components/Modal/BaseModal.js index 91b1867a6..f7300cc09 100644 --- a/src/components/Modal/BaseModal.js +++ b/src/components/Modal/BaseModal.js @@ -103,8 +103,8 @@ class BaseModal extends PureComponent { backdropColor={themeColors.modalBackdrop} backdropOpacity={hideBackdrop ? 0 : 0.5} backdropTransitionOutTiming={0}...

Won't the @henriquefalconer proposal's remove the tabbing functionality? We can't tab thought messages?

https://user-images.githubusercontent.com/16493223/201422554-0865b0e8-7831-42ca-b6ff-fbe69479b868.mp4

Yes, version 16. Other browsers are effected too and this is expected since we removed the tabindex attr in the proposed solution. Can you retest on your side?

@parasharrajat Mind checking [my proposal](https://github.com/Expensify/App/issues/12010#issuecomment-1312059021) The issue #7853 affects every key not just SHIFT which is a bit annoying

### Proposal ```diff diff --git a/src/components/EmojiPicker/EmojiPicker.js b/src/components/EmojiPicker/EmojiPicker.js index c379d9f83..75451cb47 100644 --- a/src/components/EmojiPicker/EmojiPicker.js +++ b/src/components/EmojiPicker/EmojiPicker.js @@ -56,6 +56,9 @@ class EmojiPicker extends React.Component { * @param {String} emoji */ selectEmoji(emoji) {...

@jasperhuangg I have PR waiting to be merged #12746 Should I wait till then to make a new PR? (and do i need to be unassigned then assigned again or...