Abdelhafidh Belalia
Abdelhafidh Belalia
@ancyrweb Can you please check this when you get the time. Thanks!
The `onModalHide` callback is called right after setting `isVisible` to `false`. But we will still [render](https://github.com/react-native-modal/react-native-modal/blob/ccdc86f5e5bdeca4a5baa99e960929dc7c21c5fe/src/modal.tsx#L839-L857) the `` from RNW. And it uses hooks that apply after such changes. So...
### Proposal ```diff diff --git a/node_modules/react-native-modal/dist/modal.d.ts b/node_modules/react-native-modal/dist/modal.d.ts index b63bcfc..bd6419e 100644 --- a/node_modules/react-native-modal/dist/modal.d.ts +++ b/node_modules/react-native-modal/dist/modal.d.ts @@ -161,6 +161,7 @@ export declare class ReactNativeModal extends React.Component getDeviceHeight: () => number; getDeviceWidth: ()...
that's correct, this is more a matter of design whether this should be the expected behaviour or not. Let me know if I should update my proposal given the expected...
@rushatgabhane I can't reproduce the bug. Can you give more details? https://user-images.githubusercontent.com/16493223/201962311-32cff3b4-ca81-4022-a654-5b1f4e8ecf1e.mp4
@rushatgabhane Still no bug https://user-images.githubusercontent.com/16493223/201983792-a4d7cbc7-2bc8-4e4d-bf9f-4044be90a31e.mp4 Can you try with the latest version (main branch) then apply the patch
### Proposal ```diff diff --git a/src/components/PDFView/PDFInfoMessage.js b/src/components/PDFView/PDFInfoMessage.js index 5d583db40..898983f13 100644 --- a/src/components/PDFView/PDFInfoMessage.js +++ b/src/components/PDFView/PDFInfoMessage.js @@ -1,6 +1,6 @@ import React from 'react'; import PropTypes from 'prop-types'; -import {View} from 'react-native';...
@sobitneupane > Does your proposal recreate https://github.com/Expensify/App/issues/7853 issue? Yes, the proposed fix does more harm than good. And as i said it's not effective, you can bypass the fix simply...
The discussion on #7853 is conflicting. You either use both TAB and SHIFT or you don't. SHIFT is also used select a message, example TAB+SHIFT to select the previous message....
### Proposal (Updated) ```diff diff --git a/src/components/PDFView/PDFInfoMessage.js b/src/components/PDFView/PDFInfoMessage.js index 5d583db40..898983f13 100644 --- a/src/components/PDFView/PDFInfoMessage.js +++ b/src/components/PDFView/PDFInfoMessage.js @@ -1,6 +1,6 @@ import React from 'react'; import PropTypes from 'prop-types'; -import {View} from...