Abdelhafidh Belalia
Abdelhafidh Belalia
The problem is the swap of `withPersonalDetails`/`withCurrentUserPersonalDetails` in ReactionTooltipContent. 1. `withCurrentUserPersonalDetails` uses `withOnyx` and this HOC at the very first render returns [`null`](https://github.com/Expensify/react-native-onyx/blob/0fbe0a4d077f96c4bc30b0b14359f634b271b03b/lib/withOnyx.js#L161). 2. Technically returning `null` means that the...
## Reviewer Checklist - [X] I have verified the author checklist is complete (all boxes are checked off). - [X] I verified the correct issue is linked in the `###...
Thanks @marcaaron and @hayata-suenaga. Let's get this merged.
I was able to reproduce too. Unrelated but on staging.new.expensify.com we are not getting redirected to the concierge chat.
@hoangzinh Thanks for the proposal. I don't think your RCA is entirely correct `LogOutPreviousUserPage` indeed does not perform any navigation so we are as you said stuck. But I think...
I think the bug is a regression from https://github.com/Expensify/App/pull/16043. That PR [adds](https://github.com/Expensify/App/blob/88644166f51c9f7ea8211df0b9afee1ca4784700/src/components/DeeplinkWrapper/index.website.js#L54-L71) the `/transition` prefix to all deeplinks. - So if the url is https://staging.new.expensify.com/transition?exitTo=GOODPLACE - It will become https://staging.new.expensify.com/transition?exitTo=%2Ftransition%3FexitTo%3DGOODPLACE...
@hoangzinh Feel free to update your proposal. But I think it may be better to revert the PR since it was build on a wrong concept; The `/transition` root is...
@ntdiary I think it's a regression from that PR because only that PR adds the `/transition` prefix which breaks all desktop deeplinks for olddot links. Are you planning to remove...