Abdelhafidh Belalia
Abdelhafidh Belalia
> If the pdf uploaded is protected, it shows the FullScreenLoadingIndicator That may confuse the user, can we show instead the generic pdf thumbnail?
Indeed we would have to read the file to determine if it's password-protected. I think this new behaviour https://github.com/Expensify/App/pull/35255#issuecomment-1944087612 is still better than `main` as we won't allow the user...
## Reviewer Checklist - [X] I have verified the author checklist is complete (all boxes are checked off). - [X] I verified the correct issue is linked in the `###...
I think we should go in parallel I don't see a reason to hold the PR
To not block on this let's make it external for now (I will be C+ if C+ is needed here). I will pick this up if no one took it...
@ShridharGoel Thanks for the proposal. Overall this looks good to me 👍 🎀 👀 🎀 C+ reviewed [Link to proposal](https://github.com/Expensify/App/issues/40189#issuecomment-2053660120)
This is a regression from https://github.com/Expensify/App/pull/32471 where `react-native-vision-camera` was upgraded from `2.16.2` to `2.16.5`. I tested with `2.16.7` and that version is still buggy. Since this is a deploy blocker...
@davidcardoza @marcaaron I'm unable to reproduce this. https://user-images.githubusercontent.com/16493223/225389358-eaf0f6c3-0515-48ed-990f-2f84ad550bf3.mp4
Not overdue. I think this need reproduction. Also no proposals yet...