Lucas Kent

Results 205 comments of Lucas Kent

>Nice! But I'd put it in a separate crate/repo. Someone else will definitely find it useful and it's pretty decoupled from Shotover. That is definitely an endgoal! I think we...

>Some minor concerns with implementing this in the codec. To me this seems like it's leaking Shotover implementation details (validation and protecting our transform invariant) into the codec, which should...

As per discussion on slack I should first: * investigate upstreaming a fix so that redis returns a single request instead of the checks added by this PR * investigate...

@conorbros can this be closed now that https://github.com/shotover/shotover-proxy/pull/662 is merged?

Oh, it does mention version support as well which still isnt done

I just realized that the sinks have the same behaviour as Coalesce. Or at the very least from examining the code, it looks like RedisSinkSingle will sometimes not return the...

If we could just make metrics fast even when enabled that would be even better. :P But I also dont see too much of a problem with metrics being toggleable...

I was suggested to use the `inherit()` method on the builder which certainly improves things. I'm now getting values around ~200,000. But there are still some strange results such as...

https://github.com/actions/virtual-environments/issues/4974 https://github.community/t/getting-access-to-perf-events-on-github-hosted-ubuntu-latest/149164/4 https://stackoverflow.com/questions/60988282/perf-alternate-performance-management-tools-that-can-run-on-google-cloud-platf I found these which show that getting instruction count on GA VMs will be impossible. The only solution would be providing our own hardware or maybe there...

I edited in some details on authentication