Lucas Kent

~~## test redis_int_tests::multi~~ Should be solved by https://github.com/shotover/shotover-proxy/pull/1086 ``` shotover 04:43:36.664124Z INFO shotover_proxy::runner: Starting Shotover 0.1.9 shotover 04:43:36.664157Z INFO shotover_proxy::runner: configuration=Config { main_log_level: "info,shotover_proxy=info", observability_interface: "0.0.0.0:9001" } shotover 04:43:36.664164Z INFO...

## kafka_int_tests::passthrough_encode ``` shotover 00:11:38.791417Z INFO shotover::runner: Starting Shotover 0.1.10 shotover 00:11:38.791519Z INFO shotover::runner: configuration=Config { main_log_level: "info,shotover_proxy=info", observability_interface: "0.0.0.0:9001" } shotover 00:11:38.791551Z INFO shotover::runner: topology=Topology { sources: {"kafka_source": Kafka(KafkaConfig...

## redis_int_tests::multi ``` thread 'redis_int_tests::multi' panicked at 'assertion failed: `(left == right)` left: `Ok(0)`, right: `Ok(1)`', shotover-proxy/tests/redis_int_tests/assert.rs:16:5 stack backtrace: 0: rust_begin_unwind at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/panicking.rs:579:5 1: core::panicking::panic_fmt at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/core/src/panicking.rs:64:14 2: core::panicking::assert_failed_inner 3:...

Hi, sorry I never got around to looking at this. I think iterators are a better way to expose records and I support this change. 👍 If you are still...

Thanks 0.16.0 is already released, but will find time to review this soon.

Your change to the version logic is correct, the important thing here is that the original implementation was broken: It reads the version from the batch: https://github.com/tychedelia/kafka-protocol-rs/blob/3ca47de64d6ec65aba19d689b3547e7efa2439ea/src/records.rs#L465 Then reads the...

I agree that is a problem. I'm not sure how to solve it though. For my own use case I use kafka-protocol for a kafka proxy and I need the...

we are currently pretty flexible with breaking changes in this project, a bump to 0.15 is not an issue. You make a good point about decoding. The simplest solution is...

I'm not familiar with this problem thanks for raising. If you can add those headers and find they fix your issue feel free to open a PR

I enabled serial_test for every test. It could probably be left off for some tests, but IMO better to keep it everywhere, otherwise its easy to forget when its truly...