Lucas Kent

The readme lists statics as supporting variadics but that doesnt seem possible since static and non-static methods have the same underlying implementation and neither of them support variadics/varargs. After looking...

Looking further into it: There is a test testing that variadics works, so I must be misunderstanding the implementation. ~~However for some reason a lot of the tests fail when...

To avoid the memcpy on encode looks like we want to make use of something like: https://docs.rs/chunked-bytes/latest/chunked_bytes/loosely/struct.ChunkedBytes.html Hopefully we can find a tokio codec equivalent that works with ChunkedBytes otherwise...

This issue is describing the overhead caused by the tokio codec abstraction. Maybe its possible to avoid, but it also seems pretty fundamental to shotover's current design. Could be worth...

Hi, thanks for the PR! Unfortunately your approach wont work as that file is generated from the kafka protocol spec json files. I think this approach by kafka is a...

Huh, interesting, we use kafka-protocol for a [proxy](https://github.com/shotover/shotover-proxy) which I think is what you mean by middleware here. I think we avoided this issue in our proxy because we have...

> Similarly, brokers may still return message formats v0 and v1 with fetch v4 or higher if the relevant messages were originally written as v0/v1 and were not converted to...

I looked into this further. Turns out that even kafka 3.0 never stores records as v0/v1. If it receives v0/v1 it will convert up to v2 If it receives a...

I'm in no rush to see this in a release, but this PR is ready for review and merge.

I've done a bit of cleanup, @tychedelia can you please review this when you get the chance. (theres actually not much changes when you ignore the generated stuff)