Ruben Quesada Lopez

Results 15 comments of Ruben Quesada Lopez

[CALCITE-4777]Casting from DECIMAL to BOOLEAN throws an exception

LGTM @xuyangzhong the PR looks in a good shape, could you please squash commits into a single one so that we can merge it shortly?

[CALCITE-4777]Casting from DECIMAL to BOOLEAN throws an exception

@NobiGo my understanding was that casting decimal (and float, real, double) into boolean will be forbidden (implemented by this PR); but casting integer types into boolean is (and will continue...

[CALCITE-2743] Remove MySQL-specific Date & Time shifting

@dgloeckner apart from resolving the conflicts, a unit test should be provided in the PR: a test that fails with the current Calcite master (i.e. it shows the issue) and...

[CALCITE-4458] The "rowTypeCoercion" for "SET" operations should be "OR" relationship (Jiatao Tao)

Would it be possible to have a unit test "showing" the bug?

[CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

@Aaaaaaron thanks, great work. I have left some minor final details, otherwise LGTM

[CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

You're welcome @Aaaaaaron , thanks for your work. @vlsi you reviewed this PR some time ago, I think now it is in a pretty good shape, do you want to...

[CALCITE-4900] NullPointerException when send ExectuteRequest via protobuf with no parameters

Thanks @Logioniz for the PR. @NobiGo the PR seems in a good shape. Do you have any further comments? Otherwise I'll merge it in the coming days.

[CALCITE-6015] AssertionError during optimization of EXTRACT expression

Thanks @mihaibudiu , no further comment from my side. LGTM.

[CALCITE-6015] AssertionError during optimization of EXTRACT expression

Thanks @mihaibudiu ! @snuyanzin do you have any further remark? Otherwise IMO this PR is in a good shape to be merged.

[CALCITE-2067] RexLiteral cannot represent accurately floating point values, including NaN, Infinity

> This is a breaking change in some respect [...] Just a minor reminder: before the final merge, @mihaibudiu , I think it'd be necessary to include the corresponding comment...