[CALCITE-6015] AssertionError during optimization of EXTRACT expression

[mihaibudiu]

While attempting to fix the bug described in the issue I have discovered that many cases for EXTRACT are actually not implemented. So I implemented most of them, and I have improved the validation as well; the case indicated in the JIRA issue will now be rejected statically.

There is one case for EXTRACT which I haven't implemented: EXTRACT(EPOCH FROM INTERVAL '...' YEAR TO MONTH) because I wasn't sure how to properly use the convertlets to do it. Help would be appreciated.

This PR also makes some unexpected tiny changes in SqlValidatorImpl and SqlCall, so I would appreciate comments from people who are more knowledgeable.

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
10 Code Smells

98.3% Coverage
0.0% Duplication

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
10 Code Smells

98.3% Coverage
0.0% Duplication

[mihaibudiu]

This PR implements several instances of the EXTRACT function which weren't supported. I would appreciate a review.

[mihaibudiu]

Can anyone please review this PR?

[rubenada]

Thanks @mihaibudiu , no further comment from my side. LGTM.

[mihaibudiu]

Squashed the commits in preparation for merging.

[rubenada]

Thanks @mihaibudiu ! @snuyanzin do you have any further remark? Otherwise IMO this PR is in a good shape to be merged.

[sonarqubecloud[bot]]

Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud