calcite-avatica icon indicating copy to clipboard operation
calcite-avatica copied to clipboard

[CALCITE-4900] NullPointerException when send ExectuteRequest via protobuf with no parameters

Open Logioniz opened this issue 4 years ago • 7 comments

NullPointerException when send ExectuteRequest via protobuf with no parameters

Logioniz avatar Nov 24 '21 08:11 Logioniz

@Logioniz Please add unit test for this? Looks like a bug which can reproduce.

NobiGo avatar Dec 16 '21 03:12 NobiGo

@NobiGo done.

Logioniz avatar Dec 16 '21 21:12 Logioniz

@NobiGo can I do something else or is everything done and are we waiting for something?

Logioniz avatar Dec 19 '21 20:12 Logioniz

@Logioniz Hi, We never make commit info start with a Fixed bug... Just describe the ISSUE enough(same as JIRA summary).

NobiGo avatar Dec 23 '21 23:12 NobiGo

@NobiGo, ok, i'm squash commits to one and reword commit message.

Is there anything else I can do to help?

Logioniz avatar Dec 24 '21 20:12 Logioniz

@Logioniz Please 1)resolve the pending comment. 2)change the PR commit info meantime. 3)Before the final review, Please don't rebase the commits.

NobiGo avatar Dec 25 '21 03:12 NobiGo

@NobiGo is it ok now?

Logioniz avatar Feb 11 '22 16:02 Logioniz

Thanks @Logioniz for the PR.

@NobiGo the PR seems in a good shape. Do you have any further comments? Otherwise I'll merge it in the coming days.

rubenada avatar Oct 17 '22 14:10 rubenada