Rossen Stoyanchev

Results 488 comments of Rossen Stoyanchev

`WebMvcRegistrations` uses `WebMvcConfigurationSupport` protected methods that expose the creation of `@RequestMapping` infrastructure instances that are then further initialized, also with participation from `WebMvcConfigurer`s. So you can use `WebMvcRegistrations` to replace...

I agree that the current situation is a bit strange. The `useTrailingSlashMatch` option on RMHM tries to work as a convenience method by also setting the same on `PathPatternParser`, but...

Nice :+1: ! Yes please, a targeted backport of the cancellation propagation to CompletableFuture would be great indeed. The above linked issue is with Spring for GraphQL 1.0 and Reactor...

It shouldn't but with `exchange()` you are responsible to handle all possible response types. From a quick look, I see handling for `OK` but what if there is a different...

We are caching through `ServerWebExchange#getFormData()` and yes gateway could serialize form data but since reading the body, even indirectly via `getFormData()`, competes with Gateway trying to also read in order...

> In my opinion, this should be supported Yes, question is how. > HiddenHttpMethodFilter needs to read it `HiddenHttpMethodFilter` has no role to play and should never be needed on...

Would that also include the ability to read the body, irrespective of form data?

So then perhaps wrapping the request to intercept `getBody` and essentially cache it if accessed might be something to try.

**Team Decision:** this is worth doing to provide sufficient control over ordering. There are some design decisions to be thought through such as relative vs explicit ordering, how to refer...

**Team Decision:** We can do this in fallback mode, trying the built-in `Duration` formatting, and then falling back on alternative formats, in effect extending the built-in one. We should ensure...