Propagate cancel signal on Mono to wrapped CompletableFuture

Open rstoyanchev opened this issue 3 years ago • 2 comments

Currently, Mono#fromFuture uses MonoCompletionStage, and CompletionStage does not have a cancel method. As a result, even if the Mono is cancelled, the future is never made aware of it.

Aug 04 '22 14:08 rstoyanchev

@rstoyanchev hah! it is already fixed in 3.5.x by #3081 (https://github.com/reactor/reactor-core/pull/3081/files#diff-e815d2e7a55f9f17006048ff085897e713143567345688c33e9d64b19f911f06R149). Do we need that backported into 3.4?

Aug 04 '22 19:08 OlegDokuka

Nice :+1: ! Yes please, a targeted backport of the cancellation propagation to CompletableFuture would be great indeed. The above linked issue is with Spring for GraphQL 1.0 and Reactor 3.4.x so that would help there.

Aug 05 '22 10:08 rstoyanchev

closed with #3146

Aug 16 '22 08:08 OlegDokuka