spring-framework icon indicating copy to clipboard operation
spring-framework copied to clipboard

Add support for relative ordering

Open snicoll opened this issue 5 years ago • 5 comments

Overview

Our current support for @Order/Ordered uses an absolute number with a default value of "lowest precedence" (i.e. Integer.MAX_VALUE). We also have PriorityOrdered to override such ordering in certain scenarios.

One problem with the current default value is that it is not natural for customizers where you'd want the "default" ones to be at a given order with the ability of custom instance to run before, or after. Such a default must provide a value as there is no way to run "after" with the current default value. A natural value for that is zero with negative values being processed before and positive values being processed after.

A better way to express ordering is to express it relative to another concept. You may need to run/customize/execute before or after another "instance". In Spring Boot, we've essentially implemented that with @AutoConfigureBefore and @AutoConfigureAfter to order auto-configurations.

This issue is to discuss if there is an appetite to provide such constructs in the core framework, with an SPI that would let us order things (potentially being honored in ObjectProvider#orderedStream().

Related Issues

  • #34670

snicoll avatar Apr 02 '20 07:04 snicoll

This would be particularly nice for servlet filter registration.

andersonkyle avatar Apr 11 '20 17:04 andersonkyle

As a user, I can confirm this would be useful. The current approach I have to follow is open the bean, see if there's an order defined, and then order relative to that (hoping that it's not at the max/min in a way that would prevent going before/after it). When there isn't an order defined, I need to pull open @Order.value() to see what the default is (LOWEST_PRECEDENCE) and make sure I order relative to that.

Then I write something like the following, where the reasoning is in the comments, rather than being declarative in the code itself:

@Order(Ordered.LOWEST_PRECEDENCE - 1) // Higher precedence than SomeOtherThing

mjustin avatar Mar 03 '21 23:03 mjustin

Team Decision: this is worth doing to provide sufficient control over ordering. There are some design decisions to be thought through such as relative vs explicit ordering, how to refer to others for relative ordering, etc.

rstoyanchev avatar Aug 02 '22 08:08 rstoyanchev