Rootul P

[Suggestion] To facilitate future refactoring and considering that a specific version of this repo has been designated for use, I recommend introducing a variable to hold this version number and...

For consistency with `rpcBlockchainInfoFunc` in line 80 above (and thus readability), I would: * use `int64` * rename `beginBlock` and `endBlock` to `minHeight` and `maxHeight` _Originally posted by @sergio-mena in...

Fix data race for `env` in tendermint/tendermint

1

## Context https://github.com/celestiaorg/celestia-core/pull/869 introduces a short-term fix to prevent data races when accessing a shared global variable: `env`. ## Problem The above PR bloats the difference between tendermint/tendermint and celestia-core...

## Problem ``` $ make vulncheck Scanning your code and 587 packages across 96 dependent modules for known vulnerabilities... Vulnerability #1: GO-2024-2466 Denial of service in github.com/go-git/go-git/v5 and gopkg.in/src-d/go-git.v4 More...

## Problem Test flake ``` --- FAIL: TestReactorEventuallyRemovesExpiredTransaction (0.20s) reactor_test.go:205: Error Trace: /home/runner/work/celestia-core/celestia-core/mempool/cat/reactor_test.go:205 Error: Should be false Test: TestReactorEventuallyRemovesExpiredTransaction FAIL ``` ## Occurences 1. https://github.com/celestiaorg/celestia-core/actions/runs/6694512516/job/18259427654?pr=1128#step:6:121

## Context While bumping Go version in https://github.com/celestiaorg/celestia-core/pull/1124, I noticed that pages in `docs/*` contain tutorials from CometBFT with Go versions. ## Problem Ideally we don't maintain those docs and...

## Context https://github.com/celestiaorg/celestia-core/blob/fab117535d93c56f578eb502b8dfc3b6411096a7/README.md?plain=1#L85-L87 ## Problem celestia-core releases are now based on CometBFT releases and not Tendermint releases. ## Proposal Along the same lines as [CometBFT environment variables](https://github.com/cometbft/cometbft/blob/main/UPGRADING.md#environment-variables) we may consider...

Link: https://github.com/celestiaorg/celestia-core/actions/runs/5006490637/jobs/8971858914?pr=1011#step:6:103 ``` state_test.go:1319: Error Trace: /home/runner/work/celestia-core/celestia-core/consensus/state_test.go:1319 Error: Should be true Test: TestSetValidBlockOnDelayedProposal state_test.go:1320: Error Trace: /home/runner/work/celestia-core/celestia-core/consensus/state_test.go:1320 Error: Should be true Test: TestSetValidBlockOnDelayedProposal state_test.go:1321: Error Trace: /home/runner/work/celestia-core/celestia-core/consensus/state_test.go:1321 Error: Should be...

Propagate an error message when a tx already exists in the mempool

7

## Context https://github.com/rollkit/rollkit/issues/725 ## Problem When clients attempt to PayForData in celestia-app, celestia-core doesn't return a full error message when a tx already exists in the mempool. The `celestia-appd` binary...

Github workflow for `go mod tidy`

1

## Context https://github.com/celestiaorg/celestia-core/pull/871#discussion_r1006982465 ## Problem It is possible for a PR to be merged to this repo where `go mod tidy` hasn't been run. This is problematic because when developers...